refactor(config): rename 'known/unknown' to 'built-in/plugin' terminology#5214
Open
MikeGoldsmith wants to merge 5 commits into
Open
refactor(config): rename 'known/unknown' to 'built-in/plugin' terminology#5214MikeGoldsmith wants to merge 5 commits into
MikeGoldsmith wants to merge 5 commits into
Conversation
Update docstrings, comments, and test names to use clearer terminology for components that are built into the SDK vs loaded via entry points as plugins. Covers the already-merged sampler PR and shared infrastructure. The pending propagator, exporter, and resource detector PRs will need the same rename applied when they merge. Assisted-by: Claude Opus 4.6
…n' into mike/config-rename-builtin-plugin
herin049
approved these changes
May 19, 2026
| Known sampler types are checked via typed fields on the Sampler | ||
| dataclass. Unknown sampler names captured in additional_properties | ||
| Built-in sampler types are checked via typed fields on the Sampler | ||
| dataclass. Plugin sampler names captured in additional_properties |
Contributor
There was a problem hiding this comment.
I don't have a huge preference here, but personally I still find the term "plugin" to be a big vague here. I personally think that user-defined might work a bit better here and pairs well with the built-in terminology.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Renames "known" and "unknown" to "built-in" and "plugin" in the declarative config plugin loading code. The old terms mapped to JSON Schema internals (
propertiesvsadditionalProperties), but "built-in" and "plugin" are clearer from a user's perspective.Suggested by @tammy-baylis-swi in #5128.
Scope
Docstrings, comments, and test names across:
_common.py—_additional_propertiesdecorator docstring_tracer_provider.py— sampler factory docstring and error messagecodegen/README.mdandcodegen/dataclass.jinja2— template commentstest_tracer_provider.py— test method namesNo functional changes — terminology only.
Closes #5195